Adding feature tracking operator by A-Gainford · Pull Request #2148 · MetOffice/CSET

Adam Gainford (A-Gainford) · 2026-05-19T12:39:16Z

Adding feature-tracking via the Simple-Track repo (https://github.com/ParaChute-UK/simple-track), which is included as a new dependency. The feature.track operator is used to call Simple-Track, which returns three cubes per timestep: "feature_id", "feature_lifetime" and "feature_init". These can be filtered to select them for plotting with existing routines. Other data which is not currently used by CSET can be saved for further analysis. The new "feature" operator set will also be used to implement cell stats using Simple-Track with the tracking capabilities disabled (though the "feature" name may want to be changed).

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

Documentation has been updated to reflect change.
New code has tests, and affected old tests have been updated.
All tests and CI checks pass.
Ensured the pull request title is descriptive.
Ensure rose-suite.conf.example has been updated if new diagnostic added.
Conda lock files have been updated if dependencies have changed.
Attributed any Generative AI, such as GitHub Copilot, used in this PR.
Marked the PR as ready to review.

James Frost (jfrost-mo)

Thank you for this pull request, and sorry it took so long for me to get to it. I'm assuming that despite it being a draft PR it is ready for a review.

Overall it looks like a good set of changes that will nicely integrate simple-track into CSET. There are a few small issues highlighted in the comments below, but it is overall looking very good.

Please run the pre-commit checks over this code (pre-commit run --all-files) to fix a number of minor issues. These checks can be set to run on each commit by running pre-commit install.

Adam Gainford (A-Gainford)

Thanks for the taking a look through the code, happy with the suggestions. I assume it's okay to accept changes on the lockfiles at the bottom of the PR page but I have held off for now

James Frost (Fraetor)

Still need to review the feature file.

James Frost (jfrost-mo)

Looking good. There are a couple very minor cleanup suggestions, but once the checks are passing this should be good to merge.

James Frost (jfrost-mo) · 2026-07-06T09:23:18Z

Branch will need rebasing to fix conflicts. Easiest thing to do is probably just to take the main branch versions of the lock files then re-resolve them all.

Co-authored-by: Copilot <copilot@github.com>

Remove whitespace Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update copyright Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update lock files

github-actions · 2026-07-06T11:34:50Z

Total coverage: 91% (HTML report)

Name                                                              Stmts   Miss Branch BrPart  Cover
---------------------------------------------------------------------------------------------------
src/CSET/__init__.py                                                 93      2     12      0    98%
src/CSET/_common.py                                                 149      0     52      0   100%
src/CSET/cset_workflow/app/fetch_fcst/bin/fetch_data.py             115     27     24      0    79%
src/CSET/cset_workflow/app/finish_website/bin/finish_website.py      70      0      4      0   100%
src/CSET/cset_workflow/app/parbake_recipes/bin/parbake.py            29      0      8      0   100%
src/CSET/cset_workflow/app/send_email/bin/send_email.py              25      0      4      0   100%
src/CSET/cset_workflow/lib/python/jinja_utils.py                     17      0      6      0   100%
src/CSET/extract_workflow.py                                         47      0     16      0   100%
src/CSET/graph.py                                                    43      0     14      0   100%
src/CSET/operators/__init__.py                                       89      0     26      0   100%
src/CSET/operators/_atmospheric_constants.py                          9      0      0      0   100%
src/CSET/operators/_colormaps.py                                    229      4     62      4    97%
src/CSET/operators/_stash_to_lfric.py                                 3      0      0      0   100%
src/CSET/operators/_utils.py                                        183      8     74      6    95%
src/CSET/operators/ageofair.py                                      141      7     64      5    94%
src/CSET/operators/aggregate.py                                      76      1     22      1    98%
src/CSET/operators/aviation.py                                       60      0     18      0   100%
src/CSET/operators/collapse.py                                      154     12     72      5    91%
src/CSET/operators/constraints.py                                   107      7     46      2    93%
src/CSET/operators/convection.py                                     37      4     10      2    87%
src/CSET/operators/ensembles.py                                      27      0     14      0   100%
src/CSET/operators/feature.py                                        41      0     10      0   100%
src/CSET/operators/filters.py                                        66      2     30      0    98%
src/CSET/operators/humidity.py                                      139      0     56      0   100%
src/CSET/operators/imageprocessing.py                                56      0     16      0   100%
src/CSET/operators/mesoscale.py                                      17      0      2      0   100%
src/CSET/operators/misc.py                                          146      0     54      1    99%
src/CSET/operators/plot.py                                          929    169    318     59    78%
src/CSET/operators/power_spectrum.py                                 97      3     30      3    95%
src/CSET/operators/precipitation.py                                  93      0     50      0   100%
src/CSET/operators/pressure.py                                       41      0     12      0   100%
src/CSET/operators/read.py                                          409     38    178     14    89%
src/CSET/operators/regrid.py                                        122     18     64      1    83%
src/CSET/operators/scoreswrappers.py                                 47      6     12      3    85%
src/CSET/operators/temperature.py                                   121      0     32      0   100%
src/CSET/operators/transect.py                                       62      0     24      0   100%
src/CSET/operators/wind.py                                           45      3     10      2    91%
src/CSET/operators/write.py                                          15      0      6      0   100%
src/CSET/recipes/__init__.py                                        101      0     28      0   100%
---------------------------------------------------------------------------------------------------
TOTAL                                                              4250    311   1480    108    91%

James Frost (jfrost-mo) · 2026-07-06T11:44:39Z

Just needs a little more tests:

A test to check an error is raised when a lat/lon cube is given to _check_xy_coords:
https://tmpweb.net/HB6wj292JII9/z_f5ac9763053bfad5_feature_py#t217
Some tests for the new custom colourmap:
https://tmpweb.net/HB6wj292JII9/z_f5ac9763053bfad5__colormaps_py#t619

Adam Gainford (A-Gainford) · 2026-07-06T12:42:45Z

Just needs a little more tests:

* A test to check an error is raised when a lat/lon cube is given to `_check_xy_coords`:
  https://tmpweb.net/HB6wj292JII9/z_f5ac9763053bfad5_feature_py#t217

* Some tests for the new custom colourmap:
  https://tmpweb.net/HB6wj292JII9/z_f5ac9763053bfad5__colormaps_py#t619

Thanks for the suggestions! Forgot about the custom colourmap

Adam Gainford (A-Gainford) requested review from Sylvia Bohnenstengel (Sylviabohnenstengel) and James Frost (jfrost-mo) May 19, 2026 12:39

Adam Gainford (A-Gainford) marked this pull request as draft June 8, 2026 14:40

James Frost (jfrost-mo) requested changes Jun 25, 2026

View reviewed changes

James Frost (jfrost-mo) mentioned this pull request Jun 25, 2026

Add Cell stats operator #2190

Draft

8 tasks

James Frost (jfrost-mo) marked this pull request as ready for review June 25, 2026 11:41

Adam Gainford (A-Gainford) commented Jun 30, 2026

View reviewed changes

Adam Gainford (A-Gainford) mentioned this pull request Jun 30, 2026

Feature.track workflow loader #2247

Draft

7 tasks

Adam Gainford (A-Gainford) requested a review from James Frost (jfrost-mo) June 30, 2026 15:53

James Frost (Fraetor) reviewed Jul 2, 2026

View reviewed changes

Comment thread src/CSET/operators/_colorbar_definition.json Outdated

Comment thread src/CSET/operators/plot.py Outdated

Comment thread .gitignore Outdated

James Frost (jfrost-mo) approved these changes Jul 6, 2026

View reviewed changes

Comment thread tests/operators/test_feature.py Outdated

Comment thread tests/operators/test_feature.py Outdated

Comment thread src/CSET/recipes/example_recipes/example_feature_track.yaml

Adam Gainford (A-Gainford) and others added 18 commits July 6, 2026 11:10

added simple-track operator and tests

4da5552

Co-authored-by: Copilot <copilot@github.com>

added example tracking recipe

43f52bf

added temporary feature cbar definitons (limits to be set dynamically)

cda1d0f

added simple-track dependency to pyproject and env.yml

abdf356

removed unnecessary logging, added set_under option to feature plot

792f49a

added restriction of xy grid spacing on input cube

f89f789

changed feature colorbar properties

511dc13

Update conda lockfiles

d821452

Update src/CSET/operators/__init__.py

e3502fc

Remove whitespace Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/feature.py

5f0e0ba

Update copyright Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update .gitignore

ceb195e

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

updated docstrings

7c2f62a

Update tests/operators/test_feature.py

89dc8c8

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/recipes/example_recipes/example_feature_track.yaml

53249e3

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update tests/operators/test_feature.py

cab9212

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

added custom feature colorbar to _colormaps

edc4fb5

replaced deprecated cmap setting method, moved to _colormaps

8632cf1

added new line to gitignore

32f05f1

Adam Gainford (A-Gainford) added 2 commits July 6, 2026 11:14

removed feature entries from _colorbar_definition.json

cab9b33

remove whitespace from example recipe

bf3b1f0

Adam Gainford (A-Gainford) force-pushed the simple-track branch from 0f3051e to bf3b1f0 Compare July 6, 2026 11:08

github-actions Bot and others added 2 commits July 6, 2026 11:15

[CI] Update conda lock files

b57fc6b

Merge pull request #2250 from MetOffice/scheduled-updates-1783336276

f385041

Update lock files

added tests for _check_xy_coords and custom_colormap_feature_tracking

671166e

Adam Gainford (A-Gainford) merged commit cf0f4a8 into main Jul 6, 2026
9 checks passed

Adam Gainford (A-Gainford) deleted the simple-track branch July 6, 2026 12:50

Uh oh!

Conversation

Adam Gainford (A-Gainford) commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist

Uh oh!

James Frost (jfrost-mo) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adam Gainford (A-Gainford) left a comment

Choose a reason for hiding this comment

Uh oh!

James Frost (Fraetor) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

James Frost (jfrost-mo) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

James Frost (jfrost-mo) commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

James Frost (jfrost-mo) commented Jul 6, 2026

Uh oh!

Adam Gainford (A-Gainford) commented Jul 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Adam Gainford (A-Gainford) commented May 19, 2026 •

edited

Loading

github-actions Bot commented Jul 6, 2026 •

edited

Loading